[tmpnet] Source tmpnet defaults from a configmap #4057
Merged
+68
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes tmpnet scheduling defaults in a Kubernetes ConfigMap rather than hardcoded flag defaults.
- Updated
EnsureDefaultConfigto accept acontext.Contextand delegate to Kube-specific defaulting - Added
KubeRuntimeConfig.ensureDefaultsto fetch scheduling labels from atmpnetConfigMap - Removed static flag defaults and manual validation for scheduling labels
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/fixture/tmpnet/network_test.go | Updated test to pass ctx into EnsureDefaultConfig |
| tests/fixture/tmpnet/network.go | Changed EnsureDefaultConfig signature and call sites to include ctx |
| tests/fixture/tmpnet/kube_runtime.go | Added ensureDefaults method to source scheduling defaults from ConfigMap |
| tests/fixture/tmpnet/flags/kube_runtime.go | Removed hardcoded flag defaults and validation for scheduling labels |
Comments suppressed due to low confidence (4)
tests/fixture/tmpnet/kube_runtime.go:58
- [nitpick] This error message references flag names, but it can also be triggered by missing keys in the ConfigMap. Consider clarifying that missing config-map entries will produce this error.
var errMissingSchedulingLabels = errors.New("--kube-scheduling-label-key and --kube-scheduling-label-value are required when exclusive scheduling is enabled")
tests/fixture/tmpnet/flags/kube_runtime.go:79
- [nitpick] Since defaults now come from a ConfigMap, update the flag usage text to mention that no in-code default is set and that users should configure the
tmpnetConfigMap.
"",
tests/fixture/tmpnet/kube_runtime.go:82
- Add unit tests for
ensureDefaultsto verify behavior when the ConfigMap contains valid defaults and when keys are missing.
func (c *KubeRuntimeConfig) ensureDefaults(ctx context.Context, log logging.Logger) error {
tests/fixture/tmpnet/network_test.go:29
- It looks like
ctxisn’t defined in this test. Consider addingctx := context.Background()and importing thecontextpackage at the top of the file.
require.NoError(network.EnsureDefaultConfig(ctx, logging.NoLog{}))
4 tasks
maru-ava
force-pushed
the
tmpnet-configmap
branch
from
24434e4 to
a16b090
Compare
4 tasks
JuanLeon2
approved these changes
Jul 18, 2025
maru-ava
force-pushed
the
tmpnet-configmap
branch
from
12e189f to
01f7270
Compare
|
Rebased |
Previously the scheduling label and value required to enable exclusive scheduling were defined as flag defaults. To enable the cluster to define these defaults, the defaults are now sourced from a configmap in the target namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously the scheduling label and value required to enable exclusive scheduling were defined as flag defaults. To enable the cluster to define these defaults, the defaults are now sourced from a configmap in the target namespace.
How this was tested
CI, manually
Need to be documented in RELEASES.md?
N/A